ngsg commented on PR #5771: URL: https://github.com/apache/hive/pull/5771#issuecomment-3038894957
> @ngsg I have one request for you. When you rebase this branch next time, I'd like you to let me know before that. I am managing what I've reviewed using GitHub's review features. I can easily check the diff when you don't rebase it. However, when we rebase it, I need to verify whether the diff originates from the rebase or your new changes. As this PR changes a lot of large files, when I got lost, I had to spend O(+8,906 −7,299) time again. I have already spent a total of at least 30 hours. I can't promise I can pay an additional 10 hours on time. As we merged the JDK 21 PR, I believe you no longer need to rebase this branch frequently. Sure, I will. It would be impossible to complete a patch of this size without the kind efforts of reviewers like you. I truly appreciate your dedication so far, and I’m also sorry to hear that the rebases caused you to spend additional time. I agree that there likely won't be any major conflicts requiring a rebase, such as the JDK upgrade, and I will not rebase the PR unless we make an explicit consensus on the necessity of doing so. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
