Aggarwal-Raghav commented on PR #5872: URL: https://github.com/apache/hive/pull/5872#issuecomment-3039837719
> The end to end approach (2.) seems a bit of an overkill. Even if the NPE is caught and logged you still have some missing entries (e.g., `queryPlan`) in the `otherInfo` map. You could probably base your test on constructing a simple `ExplainWork` object and reason about missing entries in the info map. Would that work as a unit test? Thanks for the suggestions @zabetak. I have come up with a test case showcasing the problem. Can you please review and confirm if its up to the standards? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
