zratkai commented on code in PR #5628:
URL: https://github.com/apache/hive/pull/5628#discussion_r2190330865
##########
standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java:
##########
@@ -150,7 +167,8 @@ void dropCatalog(String catName)
* @param ifExists if true, do not throw an error if the catalog does not
exist.
* @throws TException general thrift exception.
*/
- void dropCatalog(String catName, boolean ifExists) throws TException;
+ default void dropCatalog(String catName, boolean ifExists) throws TException
{
Review Comment:
Done.
##########
standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java:
##########
@@ -566,15 +600,15 @@ default void dropTable(String catName, String dbName,
String tableName)
* @throws TException Thrift transport exception
*/
@Deprecated
- void truncateTable(String dbName, String tableName, List<String> partNames)
throws MetaException, TException;
+ default void truncateTable(String dbName, String tableName, List<String>
partNames) throws MetaException, TException{}
- void truncateTable(TableName table, List<String> partNames) throws
TException;
+ default void truncateTable(TableName table, List<String> partNames) throws
TException{}
- void truncateTable(String dbName, String tableName, List<String> partNames,
- String validWriteIds, long writeId) throws TException;
+ default void truncateTable(String dbName, String tableName, List<String>
partNames,
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
