ramitg254 commented on code in PR #5947:
URL: https://github.com/apache/hive/pull/5947#discussion_r2194981787
##########
hcatalog/core/src/test/java/org/apache/hive/hcatalog/cli/TestPermsGrp.java:
##########
@@ -245,7 +245,7 @@ private int callHCatCli(String[] args) throws Exception {
private void silentDropDatabase(String dbName) throws MetaException,
TException {
try {
- for (String tableName : msc.getTables(dbName, "*")) {
+ for (String tableName : msc.getTables(dbName, "*", null)) {
Review Comment:
due to this part of code
````
if (tableType == TableType.MANAGED_TABLE || tableType ==
TableType.EXTERNAL_TABLE) {
for (Map.Entry<String, org.apache.hadoop.hive.ql.metadata.Table>
tableData : tables.entrySet()) {
matcher.reset(tableData.getKey());
if (matcher.matches()) {
if (tableData.getValue().getTableType() == tableType) {
// If tableType is the same that we are requesting,
// add table the the list
combinedTableNames.add(tableData.getKey());
} else {
// If tableType is not the same that we are requesting,
// remove it in case it was added before, as temp table
// overrides original table
combinedTableNames.remove(tableData.getKey());
}
}
}
}
```
in `SessionHiveMetaStoreClient.java`
tableType was required
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
