difin commented on code in PR #5944:
URL: https://github.com/apache/hive/pull/5944#discussion_r2195231772
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/compaction/IcebergTableOptimizer.java:
##########
@@ -116,25 +101,17 @@ public Set<CompactionInfo> findPotentialCompactions(long
lastChecked, ShowCompac
currentCompactions, skipDBs, skipTables);
}
- snapshotIdCache.put(tablePair.getKey(),
icebergTable.currentSnapshot().snapshotId());
+ snapshotIdCache.put(tablePair.getKey().getNotEmptyDbTable(),
icebergTable.currentSnapshot().snapshotId());
});
return compactionTargets;
}
- private List<String> getDatabases() {
- try {
- return client.getAllDatabases();
- } catch (TException e) {
- throw new RuntimeMetaException(e, "Error getting database names");
- }
- }
-
- private List<String> getTables(String dbName) {
+ private List<org.apache.hadoop.hive.common.TableName> getTables() {
try {
- return client.getAllTables(dbName);
- } catch (TException e) {
- throw new RuntimeMetaException(e, "Error getting table names of %s
database", dbName);
+ return IcebergTableUtil.getTableFetcher(client, null, "*",
null).getTables();
Review Comment:
This combination is what I found from trial and error, all null or all “*”
didn’t work
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
