ramitg254 commented on code in PR #5947:
URL: https://github.com/apache/hive/pull/5947#discussion_r2201747424
##########
hcatalog/core/src/test/java/org/apache/hive/hcatalog/cli/TestPermsGrp.java:
##########
@@ -245,7 +245,7 @@ private int callHCatCli(String[] args) throws Exception {
private void silentDropDatabase(String dbName) throws MetaException,
TException {
try {
- for (String tableName : msc.getTables(dbName, "*")) {
+ for (String tableName : msc.getTables(dbName, "*", null)) {
Review Comment:
yeah your point is also correct but I referenced this earlier pr regarding
cleanup: https://github.com/apache/hive/pull/3072/files
and their also:
```
client.getPartitionsByNames(catName, dbName, tableName,
Collections.singletonList(partName), true, ENGINE);
```
was replaced with:
```
GetPartitionsByNamesRequest req =
convertToGetPartitionsByNamesRequest(database, tableName,
Collections.singletonList(partName), true, ENGINE, null, null);
Partition partition =
client.getPartitionsByNames(req).getPartitions().get(0);
```
with two extra null values
so what I understood from that is despite having a separate method it is
better to have an extra param which can deal with both null as well as non null
args
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
