abstractdog commented on code in PR #5838:
URL: https://github.com/apache/hive/pull/5838#discussion_r2207526030
##########
beeline/src/java/org/apache/hive/beeline/DatabaseConnection.java:
##########
@@ -79,24 +79,7 @@ void setCompletions(boolean skipmeta) throws SQLException,
IOException {
: getDatabaseMetaData().getExtraNameCharacters();
// setup the completer for the database
- sqlCompleter = new ArgumentCompleter(
- new ArgumentCompleter.AbstractArgumentDelimiter() {
- // delimiters for SQL statements are any
- // non-letter-or-number characters, except
- // underscore and characters that are specified
- // by the database to be valid name identifiers.
Review Comment:
yes, apparently this way we would lose parsing logic, I just found jline3
commit which removed the original overridden delimiter:
https://github.com/jline/jline3/commit/8e09ee5fad9973ca6359ddae8056bf6d0614fd7d
apparently, the same implementation has been moved to the DefaultParser, so
as I'm already instantiating one, I can simply reuse the old logic by
overriding DefaultParser.isDelimiterChar()
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
