difin commented on code in PR #5957:
URL: https://github.com/apache/hive/pull/5957#discussion_r2207975103
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/compaction/IcebergTableOptimizer.java:
##########
@@ -115,21 +128,11 @@ private List<org.apache.hadoop.hive.common.TableName>
getTables() {
}
}
- private List<String> getPartitions(org.apache.iceberg.Table icebergTable) {
+ private org.apache.hadoop.hive.ql.metadata.Table getHiveTable(String dbName,
String tableName) {
Review Comment:
Done
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/compaction/IcebergTableOptimizer.java:
##########
@@ -115,21 +128,11 @@ private List<org.apache.hadoop.hive.common.TableName>
getTables() {
}
}
- private List<String> getPartitions(org.apache.iceberg.Table icebergTable) {
+ private org.apache.hadoop.hive.ql.metadata.Table getHiveTable(String dbName,
String tableName) {
try {
- return IcebergTableUtil.getPartitionNames(icebergTable,
Maps.newHashMap(), true);
- } catch (SemanticException e) {
- throw new RuntimeMetaException(e, "Error getting partition names for
Iceberg table %s", icebergTable.name());
- }
- }
-
- private Table resolveMetastoreTable(String qualifiedTableName) {
- String[] dbTableName = TxnUtils.getDbTableName(qualifiedTableName);
- try {
- return metadataCache.computeIfAbsent(qualifiedTableName,
- () -> CompactorUtil.resolveTable(conf, dbTableName[0],
dbTableName[1]));
+ return Hive.get().getTable(dbName, tableName);
Review Comment:
Fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
