deniskuzZ commented on code in PR #5976:
URL: https://github.com/apache/hive/pull/5976#discussion_r2210390845
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/utils/MetaStoreServerUtils.java:
##########
@@ -1636,27 +1638,42 @@ public static String getPartitionName(Path tablePath,
Path partitionPath, Set<St
return result;
}
- public static String getNormalisedPartitionValue(String partitionValue,
String type) {
-
- if (!NumberUtils.isParsable(partitionValue)) {
+ public static String getNormalisedPartitionValue(String partitionValue,
String type,
+ Configuration conf) {
+ if ((!NumberUtils.isParsable(partitionValue) && !Objects.equals(type,
ColumnType.STRING_TYPE_NAME)
Review Comment:
i don't understand this change:
if the partitionValue is not a number but type is String, we'll attempt to
parse the number in partitionValue - doesn't make any sense
DEFAULTPARTITIONNAME only applies to String type
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
