deniskuzZ commented on code in PR #5957:
URL: https://github.com/apache/hive/pull/5957#discussion_r2213784987


##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/compaction/IcebergTableOptimizer.java:
##########
@@ -115,27 +138,28 @@ private List<org.apache.hadoop.hive.common.TableName> 
getTables() {
     }
   }
 
-  private List<String> getPartitions(org.apache.iceberg.Table icebergTable) {
+  private org.apache.hadoop.hive.ql.metadata.Table getHiveTable(String dbName, 
String tableName) {

Review Comment:
   why not reuse 
   ````
       Table table = metadataCache.computeIfAbsent(ci.getFullTableName(), () ->
           CompactorUtil.resolveTable(conf, ci.dbname, ci.tableName));
   ````



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org

Reply via email to