difin commented on code in PR #5957:
URL: https://github.com/apache/hive/pull/5957#discussion_r2214422548
##########
ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Initiator.java:
##########
@@ -213,17 +220,22 @@ protected String resolveUserToRunAs(Map<String, String>
cache, Table t, Partitio
@Override
public void init(AtomicBoolean stop) throws Exception {
super.init(stop);
+ initExecutorService();
checkInterval =
conf.getTimeVar(HiveConf.ConfVars.HIVE_COMPACTOR_CHECK_INTERVAL,
TimeUnit.MILLISECONDS);
- compactionExecutor = CompactorUtil.createExecutorWithThreadFactory(
- conf.getIntVar(HiveConf.ConfVars.HIVE_COMPACTOR_REQUEST_QUEUE),
- COMPACTOR_INTIATOR_THREAD_NAME_FORMAT);
metricsEnabled = MetastoreConf.getBoolVar(conf,
MetastoreConf.ConfVars.METRICS_ENABLED) &&
MetastoreConf.getBoolVar(conf,
MetastoreConf.ConfVars.METASTORE_ACIDMETRICS_EXT_ON);
optimizers = Arrays.stream(MetastoreConf.getTrimmedStringsVar(conf,
MetastoreConf.ConfVars.COMPACTOR_INITIATOR_TABLE_OPTIMIZERS))
.map(this::instantiateTableOptimizer).toList();
}
+ @VisibleForTesting
+ protected void initExecutorService() {
Review Comment:
That method is marked `protected` to allow tests (in `itests`) to access it.
The method is needed only for testing that's why it also has
`@VisibleForTesting` annotation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
