zhangbutao commented on code in PR #5981:
URL: https://github.com/apache/hive/pull/5981#discussion_r2214739968
##########
jdbc/pom.xml:
##########
@@ -265,6 +265,13 @@
<include>org/apache/hadoop/yarn/api/records/ApplicationId.class</include>
</includes>
</filter>
+ <filter>
+ <artifact>io.netty:netty-common</artifact>
+ <includes>
+ <include>io/netty/util/*</include>
Review Comment:
Shade the `io.netty:netty-common
`https://github.com/apache/hive/pull/5981/commits/455b45215355b244bcd32e71640dde2c10db5bd7
I checked HIVE-24138, and it seems that HIVE-24138 is related
[netty-buffer](https://mvnrepository.com/artifact/io.netty/netty-buffer)
`io/netty/buffer/ArrowBuf`.
We just want to include `netty-common ` in this PR, so i think this change
maybe safe.
@ayushtkn Could help to double check?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
