deniskuzZ commented on code in PR #5957:
URL: https://github.com/apache/hive/pull/5957#discussion_r2217791998
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/compaction/IcebergTableOptimizer.java:
##########
@@ -79,29 +91,36 @@ public Set<CompactionInfo> findPotentialCompactions(long
lastChecked, ShowCompac
getTables().stream()
.filter(table -> !skipDBs.contains(table.getDb()))
.filter(table -> !skipTables.contains(table.getNotEmptyDbTable()))
- .map(table -> Pair.of(table,
resolveMetastoreTable(table.getNotEmptyDbTable())))
- .filter(tablePair ->
MetaStoreUtils.isIcebergTable(tablePair.getValue().getParameters()))
- .filter(tablePair -> {
- long currentSnapshotId =
Long.parseLong(tablePair.getValue().getParameters().get("current-snapshot-id"));
- Long cachedSnapshotId =
snapshotIdCache.get(tablePair.getKey().getNotEmptyDbTable());
- return cachedSnapshotId == null || cachedSnapshotId !=
currentSnapshotId;
+ .map(table -> {
+ org.apache.hadoop.hive.ql.metadata.Table hiveTable =
getHiveTable(table.getDb(), table.getTable());
Review Comment:
`hmsTable` is used in HiveIcebergStorageHandler
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
