Aggarwal-Raghav commented on code in PR #5943:
URL: https://github.com/apache/hive/pull/5943#discussion_r2228669757
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/utils/MetaStoreServerUtils.java:
##########
@@ -775,9 +786,8 @@ public static String
validateSkewedColNamesSubsetCol(List<String> skewedColNames
return copySkewedColNames.toString();
}
- public static boolean partitionNameHasValidCharacters(List<String> partVals,
- Pattern
partitionValidationPattern) {
- return getPartitionValWithInvalidCharacter(partVals,
partitionValidationPattern) == null;
+ public static boolean partitionNameHasValidCharacters(List<String> partVals,
Configuration conf) {
Review Comment:
It is referenced in `HMSHandler#partition_name_has_valid_characters()` but
we can make `getPartitionValWithInvalidCharacter` private.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
