ramitg254 commented on code in PR #5973: URL: https://github.com/apache/hive/pull/5973#discussion_r2234020561
########## ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java: ########## @@ -449,9 +430,9 @@ public class SemanticAnalyzer extends BaseSemanticAnalyzer { */ private boolean rootTasksResolved; - private TableMask tableMask; + protected TableMask tableMask; - CreateTableDesc tableDesc; + protected CreateTableDesc tableDesc; Review Comment: tableDesc is required in methods like `genFileSinkPlan ,materializeCTE, handleLineage` etc. in SA which I assumed are out of scope for CreateTableAnalyzer that's why CreateTableDesc is needed here -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org