kasakrisz commented on code in PR #5973:
URL: https://github.com/apache/hive/pull/5973#discussion_r2239460726
##########
ql/src/java/org/apache/hadoop/hive/ql/parse/BaseSemanticAnalyzer.java:
##########
@@ -233,15 +233,39 @@ public boolean isPrepareQuery() {
return prepareQuery;
}
- static final class RowFormatParams {
+ public static final class RowFormatParams {
String fieldDelim = null;
String fieldEscape = null;
String collItemDelim = null;
String mapKeyDelim = null;
String lineDelim = null;
String nullFormat = null;
Review Comment:
Maybe it would be better to pass the reference to the immutable
`RowFormatParams` instance instead of passing 6 parameters and add null check
to the getters of `CreateTableDesc`.
Anyway I understand that this would increase the size of this patch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
