deniskuzZ commented on code in PR #5997:
URL: https://github.com/apache/hive/pull/5997#discussion_r2245107454
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HMSHandler.java:
##########
@@ -3050,18 +3050,6 @@ private boolean drop_table_core(final RawStore ms, final
String catName, final S
firePreEvent(new PreDropTableEvent(tbl, deleteData, this));
tableDataShouldBeDeleted = checkTableDataShouldBeDeleted(tbl,
deleteData);
- if (tableDataShouldBeDeleted && tbl.getSd().getLocation() != null) {
Review Comment:
@zxl-333 initially, you added the permission check in HIVE-28804, mentioning
that some Hive clusters don't use Ranger and now you're removing it?
I'm not sure I understand the reasoning.
I see you've added `ms.rollbackTransaction()`. So the flow is: make a DB
call to drop the metadata, and then depending on whether the directory on the
filesystem was successfully removed, you either commit or roll back. I don't
think this is a good approach
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
