Copilot commented on code in PR #6002: URL: https://github.com/apache/hive/pull/6002#discussion_r2249904034
########## standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/properties/HMSTestBase.java: ########## @@ -145,6 +156,81 @@ public synchronized void tearDown() throws Exception { } } + /** + * This is how we created a self-signed certificate for localhost needed for https (ssl) configuration + * The keystore and truststore were generated using the following commands: + * % keytool -genkeypair -alias Hive -keyalg RSA -keysize 2048 -validity 3650 + * -storetype PKCS12 -keystore hive_keystore.p12 -storepass apache -keypass apache + * % keytool -export -alias Hive -file hive.crt -keystore hive_keystore.p12 -storepass apache + * % keytool -import -alias Hive -file hive.crt -keystore hive_truststore.p012 Review Comment: The truststore filename extension should be 'p12' not 'p012'. ```suggestion * % keytool -import -alias Hive -file hive.crt -keystore hive_truststore.p12 ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org