zabetak commented on code in PR #5998:
URL: https://github.com/apache/hive/pull/5998#discussion_r2256098952


##########
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/PlanModifierForASTConv.java:
##########
@@ -123,29 +127,35 @@ public static RelNode convertOpTree(RelNode rel, 
List<FieldSchema> resultSchema,
     return newTopNode;
   }
 
-  private static String getTblAlias(RelNode rel) {
+  private static class AliasCollector extends RelHomogeneousShuttle {
+    List<String> aliases = new ArrayList<>();

Review Comment:
   @kasakrisz The PR is now ready for review, please take a look when you get 
the chance.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org

Reply via email to