deniskuzZ commented on code in PR #5994:
URL: https://github.com/apache/hive/pull/5994#discussion_r2256384996
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergOutputCommitter.java:
##########
@@ -827,12 +832,40 @@ private static String
generateFileForCommitLocation(String location, Configurati
return generateJobLocation(location, conf, jobId) + "/task-" + taskId +
FOR_COMMIT_EXTENSION;
}
- private static void createFileForCommit(FilesForCommit writeResult, String
location, FileIO io) throws IOException {
- OutputFile fileForCommit = io.newOutputFile(location);
- try (ObjectOutputStream oos = new
ObjectOutputStream(fileForCommit.createOrOverwrite())) {
- oos.writeObject(writeResult);
+ private static void createFileForCommit(FilesForCommit writeResult, String
location, FileIO io,
+ CommitTasksInfo commitTasksInfo,
String commitTasksInfoFileLocation)
+ throws IOException {
+ if (writeResult.hasFilesForCommit()) {
Review Comment:
just return when `!writeResult.hasFilesForCommit()`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
