deniskuzZ commented on code in PR #5995:
URL: https://github.com/apache/hive/pull/5995#discussion_r2256478123
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/Catalogs.java:
##########
@@ -277,7 +271,8 @@ static Optional<Catalog> loadCatalog(Configuration conf,
String catalogName) {
*/
private static Map<String, String> getCatalogProperties(Configuration conf,
String catalogName) {
Review Comment:
catalogName or catalogType?
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/Catalogs.java:
##########
@@ -277,7 +271,8 @@ static Optional<Catalog> loadCatalog(Configuration conf,
String catalogName) {
*/
private static Map<String, String> getCatalogProperties(Configuration conf,
String catalogName) {
Map<String, String> catalogProperties = Maps.newHashMap();
- String keyPrefix = InputFormatConfig.CATALOG_CONFIG_PREFIX + catalogName;
+ String keyPrefix = REST_CATALOG_TYPE.equals(catalogName) ?
Review Comment:
catalogName or catalogType?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
