deniskuzZ commented on code in PR #5995:
URL: https://github.com/apache/hive/pull/5995#discussion_r2259554167
##########
data/conf/iceberg/llap/hive-site.xml:
##########
@@ -397,4 +397,39 @@
<name>hive.lock.sleep.between.retries</name>
<value>2</value>
</property>
+
+ <!-- -- Iceberg REST catalog specific properties -->
+ <property>
+ <name>iceberg.catalog.type</name>
+ <value>rest</value>
+ </property>
+ <property>
+ <name>iceberg.rest-catalog.uri</name>
Review Comment:
iceberg supports prefix, see spec
https://github.com/apache/iceberg/blob/main/open-api/rest-catalog-open-api.yaml#L42
trino properties are a good fit since naming supports catalog pattern.
If someone wan't to use glue catalog: `iceberg.glue-catalog.{property}`
##########
data/conf/iceberg/llap/hive-site.xml:
##########
@@ -397,4 +397,39 @@
<name>hive.lock.sleep.between.retries</name>
<value>2</value>
</property>
+
+ <!-- -- Iceberg REST catalog specific properties -->
+ <property>
+ <name>iceberg.catalog.type</name>
+ <value>rest</value>
+ </property>
+ <property>
+ <name>iceberg.rest-catalog.uri</name>
Review Comment:
iceberg supports prefix, see spec
https://github.com/apache/iceberg/blob/main/open-api/rest-catalog-open-api.yaml#L42
trino properties are a good fit since naming supports catalog pattern.
If someone wan't to use glue catalog: `iceberg.glue-catalog.{property}`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
