difin commented on code in PR #5995:
URL: https://github.com/apache/hive/pull/5995#discussion_r2261258350
##########
iceberg/iceberg-catalog/pom.xml:
##########
@@ -69,7 +69,6 @@
<dependency>
<groupId>org.apache.hive</groupId>
<artifactId>hive-exec</artifactId>
- <scope>test</scope>
Review Comment:
In the existing examples in hive code, with these inputs, we convert hive
partition fields schema to iceberg identity partition spec, like in
`HiveSchemaUtil`:
```
public static PartitionSpec spec(Schema schema, List<FieldSchema>
fieldSchemas) {
PartitionSpec.Builder builder = PartitionSpec.builderFor(schema);
fieldSchemas.forEach(fieldSchema ->
builder.identity(fieldSchema.getName().toLowerCase()));
return builder.build();
}
```
As I understand we don't want to convert to identity spec, but the
FieldSchema doesn't contain all the details about transforms. How can we do it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
