vikramahuja1001 commented on code in PR #6012:
URL: https://github.com/apache/hive/pull/6012#discussion_r2261994382
##########
standalone-metastore/metastore-client/src/main/java/org/apache/hadoop/hive/metastore/client/ThriftHiveMetaStoreClient.java:
##########
@@ -2162,6 +2162,16 @@ public List<String> listTableNamesByFilter(String
catName, String dbName, String
isClientFilterEnabled, filterHook, catName, dbName, tableNames);
}
+ @Override
+ public List<Table> listTablesByFilter(String catName, String dbName, String
filter,
+ int maxTables) throws TException {
+ List<Table> tables =
+ client.get_tables_by_filter(prependCatalogToDbName(catName, dbName,
conf), filter,
Review Comment:
Instead of adding a new GetTable_by_filter Api along with all this thrift
code, we can reuse the existing get_table_names_by_filter api and then can use
the batched implementation of TableIterable to then fetch the required table
objects to achieve the same result. No need to expose a new API here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
