zabetak commented on code in PR #58:
URL: https://github.com/apache/hive-site/pull/58#discussion_r2262240840
##########
content/docs/latest/howtorelease_27362106.md:
##########
@@ -254,6 +256,7 @@ hive-standalone-metastore-X.Y.Z-src.tar.gz: OK
4. Check that release file looks ok -- e.g., install it and run examples from
tutorial.
5. Setup your PGP keys for signing the release, if you don't have them already.
1. See <https://www.apache.org/dev/release-signing.html>,
<https://www.apache.org/dev/openpgp.html>.
+ 2. You may need PMC privileges to do this step – if you do not have such
privileges, please ping a [PMC member](http://hive.apache.org/people.html) to
do this for you.
Review Comment:
From the moment that we allow & encourage committers to serve as release
managers I think it makes sense to lift these limitations and give them
permissions to the dist area.
I started a discussion about that on the dev list. If the rest of the PMC
are onboard with the idea we can remove entirely this sentence from the release
guide.
##########
content/docs/latest/howtorelease_27362106.md:
##########
@@ -412,17 +424,20 @@ Once [three PMC members have voted for a
release](http://www.apache.org/foundati
1. Tag the release and delete the release candidate tag. Do it from the
release branch:
```
-git tag -s rel/release-X.Y.Z -m "HiveX.Y.Z release."
+git tag -s rel/release-X.Y.Z -m "Hive X.Y.Z release."
git push origin rel/release-X.Y.Z
git tag -d release-X.Y.Z-rcR
git push origin :release-X.Y.Z-rcR
```
+**NOTE:**
+If errors happen while "git tag -s", try to configure the git signing key by
"git config user.signingkey your_gpg_key_id" then rerun the command.
+This step (`git push origin rel/release-X.Y.Z`) will trigger the Hive Docker
image build and upload to Docker Hub on the [Hive Action
Page](https://github.com/apache/hive/actions/workflows/docker-GA-images.yml).
If the image build fails, click **Re-run** on the Actions page to retry or
manually build and upload it. Finally, verify whether the image has been
successfully uploaded by checking the [Docker
Hub](https://hub.docker.com/r/apache/hive/tags).
-If errors happen while "git tag -s", try to configure the git signing key by
"git config user.signingkey your_gpg_key_id" then rerun the command.
-2. Move the release artifacts to the release area of the project
(<https://dist.apache.org/repos/dist/release/hive/>). Using svn mv command is
important otherwise you may hit size limitations applying to
artifacts([INFRA-23055](https://issues.apache.org/jira/browse/INFRA-23055))
+2. Move the release artifacts to the release area of the project
(<https://dist.apache.org/repos/dist/release/hive/>). Using svn mv command is
important otherwise you may hit size limitations applying to
artifacts([INFRA-23055](https://issues.apache.org/jira/browse/INFRA-23055)).
You may need PMC privileges to do this step – if you do not have such
privileges, please ping a [PMC member](http://hive.apache.org/people.html) to
do this for you.
Review Comment:
"You may need PMC... for you". The phrase is repeated in a few places. If we
lift the limitations we can remove the sentence completely. If not we should
consider to mention somewhere at the beginning and clarify that it affects all
operations on `https://dist.apache.org/repos/dist` area.
##########
content/docs/latest/howtorelease_27362106.md:
##########
@@ -331,9 +335,17 @@ The git commit hash is:
https://github.com/apache/hive/commit/357d4906f5c806d585fd84db57cf296e12e6049b
-Voting will conclude in 72 hours.
+The vote is open for the next 72 hours and passes if a majority of at least
+three +1 PMC votes are cast.
Review Comment:
This statement is not fully correct. Having three +1 PMC votes is not enough
to release. Majority approval is also required (more positive than negative
votes). Please rephrase or add a link to the official voting policy:
https://www.apache.org/foundation/voting.html#ReleaseVotes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
