wecharyu commented on code in PR #5223: URL: https://github.com/apache/hive/pull/5223#discussion_r2267331155
########## ql/src/java/org/apache/hadoop/hive/ql/metadata/SessionHiveMetaStoreClient.java: ########## @@ -1559,36 +1562,47 @@ public boolean dropPartition(String catName, String dbName, String tableName, St } @Override - public List<Partition> dropPartitions(String catName, String dbName, String tblName, - List<Pair<Integer, byte[]>> partExprs, PartitionDropOptions options, EnvironmentContext context) + public List<Partition> dropPartitions(TableName tableName, Review Comment: All the `dropPartitions` APIs will call the new `dropPartitions(TableName...)` api, ideally it will not miss the tempTable logic for `SessionHiveMetaStoreClient`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
