difin commented on code in PR #5995:
URL: https://github.com/apache/hive/pull/5995#discussion_r2268168921


##########
iceberg/iceberg-catalog/pom.xml:
##########
@@ -69,7 +69,6 @@
     <dependency>
       <groupId>org.apache.hive</groupId>
       <artifactId>hive-exec</artifactId>
-      <scope>test</scope>

Review Comment:
   Hi @deniskuzZ ,
   Currently `HiveIcebergMetaHook#preCreateTable` calculates `PARTITION_SPEC` 
and puts it into HMS catalog properties, if we do this change then instead of 
calculating the value it will try to get it from table properties and it will 
be missing because it hadn't been calculated yet.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org

Reply via email to