ngsg commented on PR #5478: URL: https://github.com/apache/hive/pull/5478#issuecomment-3177537349
I think this is a reasonable approach. Regarding the `isTez`/`isLlap` issue in `VectorGroupByOperator`, I'm inclined to use `isTez` and drop `isLlap`, as `VectorGroupByOperator` checks overall heap usage via `gcCanary`, not `MemoryMXBean#getHeapMemoryUsage` and `memoryThreshold`. However, I'm not certain whether Tez without LLAP also respects `getConf().getMaxMemoryAvailable()`, so it would be nice if others could confirm this as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
