ayushtkn commented on code in PR #5990:
URL: https://github.com/apache/hive/pull/5990#discussion_r2268665816
##########
common/src/java/org/apache/hadoop/hive/common/FileUtils.java:
##########
@@ -843,6 +843,9 @@ public static boolean copy(FileSystem srcFS, Path[] srcs,
FileSystem dstFS, Path
if (!doIOUtilsCopyBytes(srcFS, srcFS.getFileStatus(src), dstFS, dst,
deleteSource, overwrite, preserveXAttr, conf, copyStatistics)) {
returnVal = false;
}
+ } catch (FileNotFoundException var15) {
+ // Wrapping the FileNotFoundException in a new IOException and
re-throw immediately.
+ throw new IOException("Copy operation failed", var15);
Review Comment:
Why do we need to have it in Cause, if the exception itself is FNF. If the
original exception is non retriable, it should bail out there itself, it
shouldn't go for checking the cause itself, if it isn't a match then only it
should progress on checking the cause
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
