zabetak commented on code in PR #60: URL: https://github.com/apache/hive-site/pull/60#discussion_r2269024328
########## content/Development/desingdocs/DEFAULT-Keyword.md: ########## @@ -11,7 +11,7 @@ We propose to add DEFAULT keyword in INSERT INTO, UPDATE and MERGE statements to # Background -With the addition of [DEFAULT constraint]({{< ref "75969407" >}}) ([HIVE-18726](https://issues.apache.org/jira/browse/HIVE-18726)) user can define columns to have default value which will be used in case user doesn’t explicitly specify it while INSERTING data. For DEFAULT constraint to kick in user has to explicitly specify column schema leaving out the column name for which user would like the sytem to use DEFAULT value. e.g. INSERT INTO TABLE1(COL1, COL3) VALUES(1,3). This statement leaves COL2 from the schema so that Hive could insert DEFAULT value if it is defined. But if user wants to insert DEFAULT value without specifying column schema it is not possible to do so. This limitation could be overcome using DEFAULT keyword. +With the addition of [DEFAULT constraint]({{< ref "Default-Constraint" >}}) ([HIVE-18726](https://issues.apache.org/jira/browse/HIVE-18726)) user can define columns to have default value which will be used in case user doesn’t explicitly specify it while INSERTING data. For DEFAULT constraint to kick in user has to explicitly specify column schema leaving out the column name for which user would like the sytem to use DEFAULT value. e.g. INSERT INTO TABLE1(COL1, COL3) VALUES(1,3). This statement leaves COL2 from the schema so that Hive could insert DEFAULT value if it is defined. But if user wants to insert DEFAULT value without specifying column schema it is not possible to do so. This limitation could be overcome using DEFAULT keyword. Review Comment: I noticed that for the pages that we extracted a title such as `75969407` the casing of the new filename is not always consistent. As far as I see, in all existing pages the file name is always in lowercase so it would be nice if we can apply this pattern on the new filenames. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org