Indhumathi27 commented on code in PR #6021: URL: https://github.com/apache/hive/pull/6021#discussion_r2273036343
########## ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java: ########## @@ -1974,6 +1996,15 @@ public List<String> getTablesByType(String dbName, String pattern, TableType typ try { List<String> result; + if (isIceberg) { + if (type != null) { + throw new HiveException("Iceberg Tables by default is External Table"); Review Comment: should this be an exception in this case? 1. can we show it like below? ``` # Table Name Table Type test_iceberg EXTERNAL_TYPE ``` 2. Or you could handle it in analyse step itself -- In ShowTablesAnalyzer -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org