konstantinb commented on PR #6014: URL: https://github.com/apache/hive/pull/6014#issuecomment-3186211318
> Many thanks for the PR @konstantinb ! <img width="599" height="1335" alt="HIVE-29084-extra-results-before-fix" src="https://github.com/user-attachments/assets/059dd5dd-fa4f-4978-a4ff-4a09a3dce924"; /> > > I left a lot of comments in the test case but let me highlight that I really appreciate the effort that you put in crafting all those queries. Feel free to push-back on anything that you believe that needs to be retained and we can iterate more based on your feedback. @zabetak thank you very much for your thorough review. I have provided answers about code changes and built a new, fairly small set of tests. Waiting on the pipeline now. Will get back on the lineage test result changes, and to the PR description soon. Please see the following screenshot on how the old code changes test output: <img width="599" height="1335" alt="HIVE-29084-extra-results-before-fix" src="https://github.com/user-attachments/assets/5ad85590-25cf-4171-be78-6a7821bd6bbb"; /> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
