okumin commented on code in PR #6022:
URL: https://github.com/apache/hive/pull/6022#discussion_r2275352975
##########
iceberg/iceberg-catalog/src/main/java/org/apache/iceberg/hive/HiveCatalog.java:
##########
@@ -434,6 +459,7 @@ public boolean tableExists(TableIdentifier identifier) {
}
}
+
Review Comment:
Without using a REST catalog, a client retrieves table metadata through
XYZCatalog -> TableMetadataParser -> S3/HDFS/etc. With a REST catalog, a client
does it through RESTCatalog, where REST API(in our case, the servlet) serves
metadata via XYZCatalog(in our case, HiveCatalog or HMSCachingCatalog) ->
TableMetadataParser -> S3/HDFS/etc. So, TableMetadataParser might be a better
place to maintain. It can support our use case, and we can remove
HMSCachingCatalog, which uses CachingCatalog introduced for client-side caching
and utilized only in SparkCatalog and FlinkCatalog.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
