difin commented on code in PR #5995:
URL: https://github.com/apache/hive/pull/5995#discussion_r2280485525
##########
iceberg/iceberg-catalog/src/main/java/org/apache/iceberg/hive/HMSTablePropertyHelper.java:
##########
@@ -77,21 +94,13 @@ private HMSTablePropertyHelper() {
public static String translateToIcebergProp(String hmsProp) {
return ICEBERG_TO_HMS_TRANSLATION.inverse().getOrDefault(hmsProp, hmsProp);
}
+
/** Updates the HMS Table properties based on the Iceberg Table metadata. */
- public static void updateHmsTableForIcebergTable(
- String newMetadataLocation,
- Table tbl,
- TableMetadata metadata,
- Set<String> obsoleteProps,
- boolean hiveEngineEnabled,
- long maxHiveTablePropertySize,
- String currentLocation) {
- Map<String, String> parameters =
- Optional.ofNullable(tbl.getParameters()).orElseGet(Maps::newHashMap);
- Map<String, String> summary =
- Optional.ofNullable(metadata.currentSnapshot())
- .map(Snapshot::summary)
- .orElseGet(ImmutableMap::of);
+ public static void updateHmsTableForIcebergTable(String newMetadataLocation,
Table tbl, TableMetadata metadata,
+ Set<String> obsoleteProps, boolean hiveEngineEnabled, long
maxHiveTablePropertySize, String currentLocation) {
+ Map<String, String> parameters =
Optional.ofNullable(tbl.getParameters()).orElseGet(Maps::newHashMap);
Review Comment:
Formatted as in the snippet above, but can you please explain how it should
be formatted going forward?
I thought in Hive we want to have less line breaks as long as it fits line
length of 120 characters.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
