deniskuzZ commented on code in PR #5905:
URL: https://github.com/apache/hive/pull/5905#discussion_r2253515067
##########
standalone-metastore/pom.xml:
##########
@@ -544,6 +567,25 @@
</dependencies>
</dependencyManagement>
<dependencies>
+ <dependency>
+ <groupId>commons-beanutils</groupId>
+ <artifactId>commons-beanutils</artifactId>
+ <version>${beanutils.version}</version>
+ <exclusions>
Review Comment:
Why are you declaring exclusions again? What's the point in using DM then?
Why are you adding `commons-beanutils` dependency directly in a
`standalone-metastore` root pom declaration and not where it's needed (I see
declaration only in `metastore-server`)?
##########
standalone-metastore/pom.xml:
##########
@@ -544,6 +567,25 @@
</dependencies>
</dependencyManagement>
<dependencies>
+ <dependency>
+ <groupId>commons-beanutils</groupId>
+ <artifactId>commons-beanutils</artifactId>
+ <version>${beanutils.version}</version>
+ <exclusions>
Review Comment:
Why are you declaring exclusions again? What's the point in using DM then?
Why are you adding `commons-beanutils` dependency directly in a
`standalone-metastore` root pom declaration and not where it's needed (I see
declaration only in `metastore-server`)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
