Neer393 commented on PR #6020: URL: https://github.com/apache/hive/pull/6020#issuecomment-3204392565
> > Okay so for this fix should I create a new JIRA or as I am working on https://issues.apache.org/jira/browse/HIVE-28974 which is related to IcebergHouseKeeperService only should I attach the fix in this JIRA ? > > @Neer393 [HIVE-28952](https://issues.apache.org/jira/browse/HIVE-28952) addendum should be OK. 1 ask: can we use `TableIterator` in `IcebergTableOptimizer` as well? Okay in that case @okumin please do not revert the PR. As per @deniskuzZ I would put an addendum to it. @deniskuzZ using `TableIterator` in `IcebergTableOptimizer` for `getTableNames()` is not a big deal. I mean we can add it but the question is do we want to as we added TableIterator as a single list of HMS API Table objects would be a burden as table objects are big in size but TableName objects are very small with only 3 strings for tablename, dbname and catalogname. So I don't think we require TableIterator as such for TableOptimizer but if you say so I can add it. I say the call is your's. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
