difin commented on code in PR #5995:
URL: https://github.com/apache/hive/pull/5995#discussion_r2288525037
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/InputFormatConfig.java:
##########
@@ -69,23 +69,17 @@ private InputFormatConfig() {
public static final int COMMIT_TABLE_THREAD_POOL_SIZE_DEFAULT = 10;
public static final String COMMIT_FILE_THREAD_POOL_SIZE =
"iceberg.mr.commit.file.thread.pool.size";
public static final int COMMIT_FILE_THREAD_POOL_SIZE_DEFAULT = 10;
- public static final String WRITE_TARGET_FILE_SIZE =
"iceberg.mr.write.target.file.size";
public static final String CASE_SENSITIVE = "iceberg.mr.case.sensitive";
public static final boolean CASE_SENSITIVE_DEFAULT = true;
public static final String CATALOG_NAME = "iceberg.catalog";
- public static final String HADOOP_CATALOG = "hadoop.catalog";
- public static final String HADOOP_TABLES = "hadoop.tables";
public static final String HIVE_CATALOG = "hive.catalog";
- public static final String ICEBERG_SNAPSHOTS_TABLE_SUFFIX = ".snapshots";
- public static final String SNAPSHOT_TABLE = "iceberg.snapshots.table";
- public static final String SNAPSHOT_TABLE_SUFFIX = "__snapshots";
public static final String CATALOG_CONFIG_PREFIX = "iceberg.catalog.";
- public static final String CATALOG_TYPE_TEMPLATE = "iceberg.catalog.%s.type";
- public static final String CATALOG_WAREHOUSE_TEMPLATE =
"iceberg.catalog.%s.warehouse";
- public static final String CATALOG_CLASS_TEMPLATE =
"iceberg.catalog.%s.catalog-impl";
+ public static final String CATALOG_CUSTOM_CONFIG_PREFIX =
"iceberg.%s-catalog";
+ public static final String CATALOG_CONFIG_TYPE = CATALOG_CONFIG_PREFIX +
".type";
Review Comment:
Restored.
Should we move all these configs from `InputFormatConfig` to `CatalogUtils`?
```
public static final String CUSTOM_CATALOG_CONFIG_PREFIX =
"iceberg.%s-catalog";
public static final String CATALOG_CONFIG_TYPE = CATALOG_CONFIG_PREFIX +
".type";
public static final String CATALOG_WAREHOUSE_TEMPLATE =
CUSTOM_CATALOG_CONFIG_PREFIX + ".warehouse";
public static final String CATALOG_DEFAULT_CONFIG_PREFIX =
"iceberg.catalog-default.";
```
In the original Iceberg's `InputFormatConfig` only this configs is there:
`public static final String CATALOG_CONFIG_PREFIX = "iceberg.catalog.";`
EDIT: moved those configs to CatalogUtils because some of them are needed in
iceberg-catalog module, please advise if this is not ok.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
