Re: [PR] HIVE-29106: When drop a table, there is no need to verify the directo… [hive]

Thu, 21 Aug 2025 18:19:22 -0700 


zxl-333 commented on code in PR #5997:
URL: https://github.com/apache/hive/pull/5997#discussion_r2292456617


##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HMSHandler.java:
##########
@@ -3050,18 +3050,6 @@ private boolean drop_table_core(final RawStore ms, final 
String catName, final S
       firePreEvent(new PreDropTableEvent(tbl, deleteData, this));
 
       tableDataShouldBeDeleted = checkTableDataShouldBeDeleted(tbl, 
deleteData);
-      if (tableDataShouldBeDeleted && tbl.getSd().getLocation() != null) {

Review Comment:
   The core-site has already set these parameters.
   **steps:**
   1、create database and table
   
![24bf816baa5448ed92ef7269d72c83f1_compress](https://github.com/user-attachments/assets/38532af1-13cd-4645-b46c-7d2e7c6ec0be)
   2、Check the HDFS permissions for the database and table
   
![0a25709a32c2ed837f03c68cbf32d851_compress](https://github.com/user-attachments/assets/276e8134-891e-4e1b-b7fe-ea07f627d14c)
   3、Grant all permissions to the dmp_query user through the ranger 
authorization.
   
![1dfedc7f796e09fc67dcdc5be1e2be59_compress](https://github.com/user-attachments/assets/ae6aeebc-e35d-4dae-ad01-efa800e9688d)
   
![9cca9ae0906ab9a47fcb7e18623d4d4f_compress](https://github.com/user-attachments/assets/6d55debc-874b-49f7-98c7-4eb6ac56d57d)
   4、Verify whether the dmp_query user has write permissions
   
![73e4316733764c64bde4c67767b6054f_compress](https://github.com/user-attachments/assets/582c18f9-7ce9-4ca8-a0b1-e40fa2681027)
   5、Use the dmp_query user to drop this table
   
![b286af7dd47afffdffbe0d65c0f9781e_compress](https://github.com/user-attachments/assets/25945e11-1b96-4e3e-a105-45a192b72fb8)
   We observed that although ranger was authorized, the inability to delete was 
caused by the permission verification stored in HDFS.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to