jiihye commented on code in PR #5793:
URL: https://github.com/apache/hive/pull/5793#discussion_r2292859413
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java:
##########
@@ -1984,14 +1984,28 @@ private StringBuilder
appendSimpleCondition(StringBuilder builder,
private StringBuilder appendCondition(StringBuilder builder,
String fieldName, String[] elements, boolean pattern, List<String>
parameters) {
+ return appendCondition(builder, fieldName, elements, pattern, parameters,
false);
+ }
+
+ private StringBuilder appendPatternConditionCaseSensitive(StringBuilder
builder,
+ String fieldName, String elements, List<String> parameters) {
+ elements = normalizeIdentifier(elements);
+ return appendCondition(builder, fieldName, elements.split("\\|"), true,
parameters, true);
Review Comment:
@deniskuzZ
I’ve rebased the branch, and now the only remaining diff is in
ObjectStore.java as shown above.
```
$ git diff upstream/master...HEAD
diff --git
a/standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java
b/standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java
index 7836ad0f0f..c540842af6 100644
---
a/standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java
+++
b/standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java
@@ -2033,7 +2033,7 @@ private StringBuilder appendCondition(StringBuilder
builder,
int length = builder.length();
for (String element : elements) {
if (pattern) {
- element = "(?i)" + element.replaceAll("\\*", ".*");
+ element = element.replaceAll("\\*", ".*");
}
parameters.add(element);
if (builder.length() > length) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
