deniskuzZ commented on code in PR #5950:
URL: https://github.com/apache/hive/pull/5950#discussion_r2293469689
##########
ql/src/java/org/apache/hadoop/hive/ql/ddl/misc/msck/MsckOperation.java:
##########
@@ -75,7 +78,25 @@ public int execute() throws HiveException, IOException,
TException, MetastoreExc
MsckInfo msckInfo = new MsckInfo(SessionState.get().getCurrentCatalog(),
tableName.getDb(), tableName.getTable(),
desc.getFilterExp(), desc.getResFile(), desc.isRepairPartitions(),
desc.isAddPartitions(), desc.isDropPartitions(),
partitionExpirySeconds);
- return msck.repair(msckInfo);
+ int result = msck.repair(msckInfo);
+ if (msckInfo.getSmallFilesStats() != null &&
!msckInfo.getSmallFilesStats().isEmpty()){
+ List<String> logInfo = new
ArrayList<>(msckInfo.getSmallFilesStats().size());
+ for (Map.Entry<String, String> me :
msckInfo.getSmallFilesStats().entrySet()){
+ String partitionName = me.getKey();
+ String smallFilesStats = me.getValue();
+ logInfo.add("This table/partition average file size is less than
Hive average file size.\n " +
Review Comment:
should this be under warn?
##########
ql/src/java/org/apache/hadoop/hive/ql/ddl/misc/msck/MsckOperation.java:
##########
@@ -75,7 +78,25 @@ public int execute() throws HiveException, IOException,
TException, MetastoreExc
MsckInfo msckInfo = new MsckInfo(SessionState.get().getCurrentCatalog(),
tableName.getDb(), tableName.getTable(),
desc.getFilterExp(), desc.getResFile(), desc.isRepairPartitions(),
desc.isAddPartitions(), desc.isDropPartitions(),
partitionExpirySeconds);
- return msck.repair(msckInfo);
+ int result = msck.repair(msckInfo);
+ if (msckInfo.getSmallFilesStats() != null &&
!msckInfo.getSmallFilesStats().isEmpty()){
+ List<String> logInfo = new
ArrayList<>(msckInfo.getSmallFilesStats().size());
+ for (Map.Entry<String, String> me :
msckInfo.getSmallFilesStats().entrySet()){
+ String partitionName = me.getKey();
+ String smallFilesStats = me.getValue();
+ logInfo.add("This table/partition average file size is less than
Hive average file size.\n " +
+ "The partition name is " + partitionName + ". " +
smallFilesStats);
+ }
+ SessionState ss = SessionState.get();
+ if (ss != null && ss.getConsole() != null) {
+ ss.getConsole().printInfo("[MSCK] Small files detected.");
+ for (String line : logInfo) {
+ ss.getConsole().printInfo("[MSCK] " + line);
+ }
+ }
+ LOG.info("There are small files exist.\n{}", String.join("\n",
logInfo));
Review Comment:
should this be under warn?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
