deniskuzZ commented on code in PR #5995:
URL: https://github.com/apache/hive/pull/5995#discussion_r2294063259
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/Catalogs.java:
##########
@@ -272,26 +274,33 @@ static Optional<Catalog> loadCatalog(Configuration conf,
String catalogName) {
private static Map<String, String> getCatalogProperties(Configuration conf,
String catalogName) {
Map<String, String> catalogProperties = Maps.newHashMap();
- String keyPrefix;
- if (ICEBERG_DEFAULT_CATALOG_NAME.equals(catalogName)) {
- keyPrefix = InputFormatConfig.CATALOG_CONFIG_PREFIX + catalogName;
- } else {
- keyPrefix =
String.format(InputFormatConfig.CUSTOM_CATALOG_CONFIG_PREFIX, catalogName);
- catalogProperties.put(CatalogUtil.ICEBERG_CATALOG_TYPE,
-
conf.get(MetastoreConf.ConfVars.HIVE_ICEBERG_CATALOG_TYPE.getVarname()));
- }
+ List<String> keyPrefixes = List.of(
+ InputFormatConfig.CATALOG_CONFIG_PREFIX + catalogName,
Review Comment:
that doesn't look nice.
catalogName or catalogType ?
should we then use `InputFormatConfig.CATALOG_CONFIG_PREFIX + catalogType`
everywhere?
in iceberg: `iceberg.catalog.glue.warehouse`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
