abstractdog commented on PR #6010: URL: https://github.com/apache/hive/pull/6010#issuecomment-3216318092
I believe the relationship between this PR and this codepath below should be clarified: https://github.com/apache/hive/blob/df98c2e2f4e2370c603f8873f006ee8728afa8a6/ql/src/java/org/apache/hadoop/hive/ql/io/protobuf/ProtobufMessageInputFormat.java#L67-L75 If this PR calls the new RecordReader a SafeRecordReader, then maybe we need to change it to distinguish between the two "safe" things: 1. here we can call it IgnoreEOFProtoMessageRecordReader 2. create class javadoc comment on IgnoreEOFProtoMessageRecordReader to explicitly say that this record reader simply returns false from the next method when it reaches EOF during read (which is not the same what the parent does) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
