deniskuzZ commented on code in PR #6024:
URL: https://github.com/apache/hive/pull/6024#discussion_r2306756597
##########
shims/common/src/main/java/org/apache/hadoop/hive/shims/Utils.java:
##########
@@ -117,14 +164,23 @@ public AppConfigurationEntry[]
getAppConfigurationEntry(String appName) {
Map<String, String> krbOptions = new HashMap<String, String>();
if (IBM_JAVA) {
krbOptions.put("credsType", "both");
- krbOptions.put("useKeytab", keyTabFile);
+ if (keyTabFile != null) {
+ krbOptions.put("useKeytab", keyTabFile);
Review Comment:
ok, the naming is a bit confusing — in one place it’s a string, while in
another it’s a boolean. maybe we should add a comment with link to
https://www.ibm.com/docs/en/semeru-runtime-ce-z/11.0.0?topic=differences-jaas-options-kerberos-login
?
````
krbOptions.put("useKeytab", keyTabFile);
} else {
if (keyTabFile != null) {
krbOptions.put("useKeyTab", "true");
````
##########
shims/common/src/main/java/org/apache/hadoop/hive/shims/Utils.java:
##########
@@ -117,14 +164,23 @@ public AppConfigurationEntry[]
getAppConfigurationEntry(String appName) {
Map<String, String> krbOptions = new HashMap<String, String>();
if (IBM_JAVA) {
krbOptions.put("credsType", "both");
- krbOptions.put("useKeytab", keyTabFile);
+ if (keyTabFile != null) {
+ krbOptions.put("useKeytab", keyTabFile);
Review Comment:
the naming is a bit confusing — in one place it’s a string, while in another
it’s a boolean. maybe we should add a comment with link to
https://www.ibm.com/docs/en/semeru-runtime-ce-z/11.0.0?topic=differences-jaas-options-kerberos-login
?
````
krbOptions.put("useKeytab", keyTabFile);
} else {
if (keyTabFile != null) {
krbOptions.put("useKeyTab", "true");
````
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
