Neer393 commented on code in PR #6046: URL: https://github.com/apache/hive/pull/6046#discussion_r2307905998
########## standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift: ########## @@ -2619,7 +2619,7 @@ service ThriftHiveMetastore extends fb303.FacebookService void create_catalog(1: CreateCatalogRequest catalog) throws (1:AlreadyExistsException o1, 2:InvalidObjectException o2, 3: MetaException o3) void alter_catalog(1: AlterCatalogRequest rqst) throws (1:NoSuchObjectException o1, 2:InvalidOperationException o2, 3:MetaException o3) GetCatalogResponse get_catalog(1: GetCatalogRequest catName) throws (1:NoSuchObjectException o1, 2:MetaException o2) - GetCatalogsResponse get_catalogs() throws (1:MetaException o1) + GetCatalogsResponse get_catalogs(1: GetCatalogRequest pattern) throws (1:MetaException o1) Review Comment: Yes but under the hood it calls get_catalogs(null) so ideally it fetches all the catalogs. I don't think it's a breaking change as I have made changes everywhere where get_catalogs is used -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
