deniskuzZ commented on code in PR #4899:
URL: https://github.com/apache/hive/pull/4899#discussion_r2324772328
##########
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezProcessor.java:
##########
@@ -185,22 +184,21 @@ public void initialize() throws IOException {
Configuration conf =
TezUtils.createConfFromUserPayload(getContext().getUserPayload());
this.jobConf = new JobConf(conf);
this.jobConf.getCredentials().mergeAll(UserGroupInformation.getCurrentUser().getCredentials());
- this.processorContext = getContext();
initTezAttributes();
- ExecutionContext execCtx = processorContext.getExecutionContext();
+ ExecutionContext execCtx = getContext().getExecutionContext();
if (execCtx instanceof Hook) {
((Hook)execCtx).initializeHook(this);
}
- setupMRLegacyConfigs(processorContext);
+ setupMRLegacyConfigs(getContext());
perfLogger.perfLogEnd(CLASS_NAME, PerfLogger.TEZ_INITIALIZE_PROCESSOR);
}
private void initTezAttributes() {
Review Comment:
4/8 bytes to store the object ref? it's nothing
````
Use a method parameter over class property for data that is needed for a
single, specific operation.
This is transient data that defines what a particular method does, not what
the object is
````
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
