thomasrebele commented on code in PR #5482:
URL: https://github.com/apache/hive/pull/5482#discussion_r2324887887
##########
ql/src/java/org/apache/hadoop/hive/ql/cache/results/QueryResultsCache.java:
##########
@@ -671,6 +674,15 @@ public void notifyTableChanged(String dbName, String
tableName, long updateTime)
*/
private boolean entryMatches(LookupInfo lookupInfo, CacheEntry entry,
Set<CacheEntry> entriesToRemove) {
QueryInfo queryInfo = entry.getQueryInfo();
+
+ if(!queryInfo.getInputs()
+ .stream()
+ .map(ReadEntity::getTable)
+ .map(Table::getTTable)
Review Comment:
@deniskuzZ, could you please elaborate your concerns a bit more? I'm not
familiar with Hive's source code yet, so please provide some context.
I tried to create a similar test case that uses materialized views, however,
with non-transactional tables I get an error
`org.apache.hadoop.hive.ql.parse.SemanticException: Automatic rewriting for
materialized view cannot be enabled if the materialized view uses
non-transactional tables`, and with transactional tables I get an error
`org.apache.hadoop.hive.ql.metadata.HiveException: MetaException(message:Cannot
drop table as it is used in the following materialized views
[default.author_mv])` when trying to drop the table that the MV depends on.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
