thomasrebele commented on code in PR #6062: URL: https://github.com/apache/hive/pull/6062#discussion_r2329697967
########## ql/src/test/queries/clientpositive/antijoin3.q: ########## @@ -0,0 +1,39 @@ +SET hive.vectorized.execution.enabled=false; +set hive.mapred.mode=nonstrict; +SET hive.auto.convert.join=false; +SET hive.auto.convert.anti.join=true; +-- SORT_QUERY_RESULTS + +create table antijoin3_t1 (t1id int not null, t1notnull string not null, t1nullable string); +create table antijoin3_t2 (t2id int not null, t2notnull string not null, t2nullable string); + +insert into antijoin3_t1 values +(0, "val_0", null), +(1, "val_1", null), +(2, "val_2", "val_2"), +(3, "val_3", "val_3"), +(4, "val_4", "val_4"); + +insert into antijoin3_t2 values +(0, "val_0", null), +(1, "val_1", null), +(4, "val_4", "val_4"), +(5, "val_5", "val_5"); + +-- do not introduce anti-join if filtering a nullable column with IS NULL Review Comment: Calcite handles the nullability propagation, so it should be correct. I've added a test query to be sure. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
