zabetak commented on code in PR #6073:
URL: https://github.com/apache/hive/pull/6073#discussion_r2339109236
##########
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java:
##########
@@ -5607,11 +5607,16 @@ public static enum ConfVars {
HIVE_MM_AVOID_GLOBSTATUS_ON_S3("hive.mm.avoid.s3.globstatus", true,
"Whether to use listFiles (optimized on S3) instead of globStatus when
on S3."),
+ HIVE_IGNORE_REMOVED_CONFIGS_LIST("hive.ignore.removed.configs.list",
+ "",
+ "Comma separated list of configuration options which are removed
from hive code. Silently ignore if the user tries to set them"),
+
Review Comment:
I don't think we need a new property since this complicates the deprecation
and removal of properties even more. `hive.conf.validation` seems to be enough
for skipping validation although I don't like much this flag either.
##########
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java:
##########
@@ -7261,6 +7266,10 @@ public static String generateDeprecationWarning() {
+ "versions. Please adjust DDL towards the new semantics.";
}
+ public static String generateRemovedWarning() {
+ return "This config does not exist in the current version of Hive.
Consider removing this config.";
+ }
+
Review Comment:
There are better ways to log warning about deprecated/removed properties.
See: `org.apache.hadoop.conf.Configuration#addDeprecation`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
