kasakrisz commented on PR #6070: URL: https://github.com/apache/hive/pull/6070#issuecomment-3291046874
> Thank you for the patch! I'm wondering whether it would make sense to insert quotes only for those identifiers where it is mandatory? A quick check that works for the majority of the identifiers would reduce the size of the patch. E.g., quotes could be avoided for identifiers that start with [a-zA-Z_] and continue with [a-zA-Z_0-9]*. Thanks for the review @thomasrebele . Currently, Hive quotes all identifiers (except function names) for other features where the SQL text has to be generated form the AST. Example: view expanded text, query result cache key, merge rewrite, check constraints etc... If we want to introduce the check of the identifier name I would do for all similar features. In case of view expanded text it is not applicable because in that case one of the goal is to get all identifiers quoted. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
