zabetak commented on code in PR #6060:
URL: https://github.com/apache/hive/pull/6060#discussion_r2355472227
##########
ql/src/test/results/clientpositive/llap/subquery_notin.q.out:
##########
@@ -5300,20 +5300,27 @@ STAGE PLANS:
Statistics: Num rows: 16 Data size: 1728 Basic stats:
COMPLETE Column stats: COMPLETE
value expressions: _col1 (type: bigint), _col2 (type:
bigint)
Filter Operator
- predicate: (p_brand is not null and p_type is not null and
UDFToDouble(p_type) is not null) (type: boolean)
+ predicate: (p_brand is not null and p_type is not null)
(type: boolean)
Statistics: Num rows: 26 Data size: 5096 Basic stats:
COMPLETE Column stats: COMPLETE
- Group By Operator
- keys: p_brand (type: string), p_type (type: string)
- minReductionHashAggr: 0.4
- mode: hash
+ Select Operator
+ expressions: p_type (type: string), p_brand (type:
string)
outputColumnNames: _col0, _col1
- Statistics: Num rows: 24 Data size: 4704 Basic stats:
COMPLETE Column stats: COMPLETE
- Reduce Output Operator
- key expressions: _col0 (type: string), _col1 (type:
string)
- null sort order: zz
- sort order: ++
- Map-reduce partition columns: _col0 (type: string),
_col1 (type: string)
- Statistics: Num rows: 24 Data size: 4704 Basic stats:
COMPLETE Column stats: COMPLETE
+ Statistics: Num rows: 26 Data size: 5096 Basic stats:
COMPLETE Column stats: COMPLETE
+ Filter Operator
+ predicate: UDFToDouble(_col0) is not null (type:
boolean)
Review Comment:
Rather minor but it seems that now some filter operators cannot be merged
together.
##########
ql/src/test/queries/clientpositive/view_with_where_exp.q:
##########
Review Comment:
I am also curious to know if the datatype (i.e., `DOUBLE`) is important for
reproducing the problem. IF not then probably I would pick something more
straightforward like an `INT` or `STRING`.
##########
ql/src/test/results/clientpositive/llap/ppd_gby_join.q.out:
##########
@@ -322,21 +322,21 @@ STAGE PLANS:
Map Operator Tree:
TableScan
alias: src
- filterExpr: (((value < 'val_50') or (key > '2')) and (((key
> '20') and (key < '4')) or ((key > '4') and (key < '400')))) (type: boolean)
+ filterExpr: (((value < 'val_50') or key is not null) and
(((key > '20') and (key < '4')) or ((key > '4') and (key < '400')))) (type:
boolean)
Review Comment:
Is the simplification of `key > '2'` to `key is not null` valid?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
